ci: bump flint to v0.8.0, switch to allow-list, add native lint tasks#1945
Merged
zeitlinger merged 3 commits intoprometheus:mainfrom Mar 18, 2026
Merged
ci: bump flint to v0.8.0, switch to allow-list, add native lint tasks#1945zeitlinger merged 3 commits intoprometheus:mainfrom
zeitlinger merged 3 commits intoprometheus:mainfrom
Conversation
- Bump flint from v0.7.1 to v0.8.0 - Switch super-linter.env from deny-list to allow-list format - Add setup:native-lint-tools, pre-commit, and setup:pre-commit-hook tasks for local native linting Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
reviewed
Mar 13, 2026
| run = "mise run lint:super-linter -- --native --autofix" | ||
| [tasks."setup:pre-commit-hook"] | ||
| description = "Install git pre-commit hook that runs native linting" | ||
| run = "mise generate git-pre-commit --write --task=pre-commit" |
Collaborator
There was a problem hiding this comment.
might be worth adding these new commands to the readme?
Add a brief section pointing contributors to the new mise tasks for installing native lint tools and the git pre-commit hook. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
2 tasks
zeitlinger
added a commit
to grafana/flint
that referenced
this pull request
Mar 17, 2026
## Summary - Native lint mode now fails when enabled linters are missing instead of silently skipping them with a warning - Prints actionable message: `Run mise run setup:native-lint-tools to install them` - This prevents commits from passing the pre-commit hook when linters can't actually run (e.g. when `setup:native-lint-tools` failed due to a missing version file) ## Context Discovered via [prometheus/client_java#1945](prometheus/client_java#1945) where `CONTRIBUTING.md` had a 282-char line that passed the pre-commit hook because `editorconfig-checker` wasn't installed (the `v8.5.0.toml` version file was missing from flint, so `setup:native-lint-tools` couldn't install tools). ## Test plan - [ ] Verify CI passes (shellcheck, super-linter) - [ ] Test native mode with a missing tool — should now fail with actionable message instead of a warning --------- Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Wrap pre-commit hook paragraph to stay under 100 chars per line. Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
jaydeluca
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
super-linter.envfrom deny-list to allow-list format (only enables: bash, editorconfig, github-actions, git-merge-conflict-markers, json-prettier, markdown, markdown-prettier, renovate, shell-shfmt, spell-codespell, xml, yaml-prettier)setup:native-lint-tools,pre-commit, andsetup:pre-commit-hookmise tasks for local native lintingTest plan
mise run lint:super-linter -- --nativeworks locally